Skip to content

feat(iaas): onboard vpc network-range commands - #1655

Merged
marceljk merged 2 commits into
mainfrom
feat/STACKITCLI-464-onboard-vpc-network-range
Oct 12, 2026
Merged

feat(iaas): onboard vpc network-range commands#1655
marceljk merged 2 commits into
mainfrom
feat/STACKITCLI-464-onboard-vpc-network-range

Conversation

@marceljk

@marceljk marceljk commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Description

relates to STACKITCLI-464

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk
marceljk requested a review from a team as a code owner October 9, 2026 15:07
cgoetz-inovex
cgoetz-inovex reviewed Oct 9, 2026
View reviewed changes
Comment thread internal/cmd/alpha/vpc/network-range/create/create.go
Comment thread internal/cmd/alpha/vpc/network-range/delete/delete.go
Comment thread internal/cmd/alpha/vpc/network-range/update/update.go
Comment thread internal/cmd/alpha/vpc/network-range/create/create.go Outdated
Comment thread internal/cmd/alpha/vpc/network-range/create/create_test.go Outdated
Comment thread internal/cmd/alpha/vpc/network-range/update/update_test.go Outdated
@marceljk
marceljk force-pushed the feat/STACKITCLI-464-onboard-vpc-network-range branch from 81c8e2d to 2edaf08 Compare October 12, 2026 06:28
@marceljk
marceljk force-pushed the feat/STACKITCLI-464-onboard-vpc-network-range branch from 2edaf08 to 9c65e6f Compare October 12, 2026 08:51
@marceljk
marceljk enabled auto-merge (squash) October 12, 2026 08:51
@github-actions

github-actions Bot commented Oct 12, 2026

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/create 51.22% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/create 49.32% (+49.32%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/delete 26.53% (+26.53%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/describe 83.52% (+83.52%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/list 57.14% (+57.14%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/update 50.00% (+50.00%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/update 51.22% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/iaasalpha/utils 100.00% (+100.00%) 🌟
Coverage details

Compared to commit 6c1bbd1 (run #38224852834)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/create/create.go 51.22% (ø) 41 21 20
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/create/create.go 49.32% (+49.32%) 73 (+73) 36 (+36) 37 (+37) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/delete/delete.go 26.53% (+26.53%) 49 (+49) 13 (+13) 36 (+36) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/describe/describe.go 83.52% (+83.52%) 91 (+91) 76 (+76) 15 (+15) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/list/list.go 57.14% (+57.14%) 49 (+49) 28 (+28) 21 (+21) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/network_range.go 0.00% (ø) 8 (+8) 0 8 (+8)
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/update/update.go 50.00% (+50.00%) 72 (+72) 36 (+36) 36 (+36) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/update/update.go 51.22% (ø) 41 21 20
github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/vpc.go 0.00% (ø) 10 (+1) 0 10 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/iaasalpha/utils/utils.go 100.00% (+100.00%) 15 (+9) 15 (+15) 0 (-6) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/alpha/vpc/network-range/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/iaasalpha/utils/utils_test.go

@marceljk
marceljk merged commit bc46d3e into main Oct 12, 2026
5 checks passed
@marceljk
marceljk deleted the feat/STACKITCLI-464-onboard-vpc-network-range branch October 12, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgoetz-inovex cgoetz-inovex cgoetz-inovex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marceljk @cgoetz-inovex